Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ledger metrics #7622

Merged

Conversation

igorms-cons
Copy link

@igorms-cons igorms-cons commented Oct 26, 2023

Description

Add Metametrics to Ledger use cases

Fixes: #
Update files

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@igorms-cons igorms-cons self-assigned this Oct 26, 2023
@igorms-cons igorms-cons changed the base branch from main to feat/implement-ledger-keyring-into-mobile October 26, 2023 20:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (099dd30) 34.42% compared to head (703f3ad) 34.41%.

Additional details and impacted files
@@                              Coverage Diff                              @@
##           feat/implement-ledger-keyring-into-mobile    #7622      +/-   ##
=============================================================================
- Coverage                                      34.42%   34.41%   -0.02%     
=============================================================================
  Files                                           1055     1055              
  Lines                                          28197    28208      +11     
  Branches                                        2377     2378       +1     
=============================================================================
  Hits                                            9708     9708              
- Misses                                         17975    17986      +11     
  Partials                                         514      514              
Files Coverage Δ
...roveTransactionHeader/ApproveTransactionHeader.tsx 75.55% <ø> (ø)
app/core/Analytics/MetaMetrics.events.ts 100.00% <ø> (ø)
...nts/Views/ConnectHardware/SelectHardware/index.tsx 35.71% <0.00%> (-1.33%) ⬇️
app/components/Views/LedgerAccountInfo/index.tsx 4.54% <0.00%> (-0.11%) ⬇️
app/components/Views/LedgerConnect/index.tsx 9.52% <0.00%> (-0.32%) ⬇️
...onents/UI/LedgerModals/LedgerConfirmationModal.tsx 2.63% <0.00%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@igorms-cons igorms-cons marked this pull request as ready for review October 27, 2023 14:54
@igorms-cons igorms-cons requested a review from a team as a code owner October 27, 2023 14:54
@github-actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8a16e4ba-2917-4fd0-b952-dbd71295f873
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@igorms-cons igorms-cons merged commit 46c07f3 into feat/implement-ledger-keyring-into-mobile Oct 27, 2023
@igorms-cons igorms-cons deleted the feat/ledger-metrics branch October 27, 2023 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants