Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Part 4] - Ongoing Work for legacy <Text> comp replacement. #7604

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR replaces old usage of legacy component with the text component that standardizes on typography provided through theme via @metamask/design-tokens library. This will bring uniformity to all text elements on our app.

Manual testing steps

  • Fresh Install MM app and Go Through Create a New Wallet up to Create Password screen.

Screenshots/Recordings

Before

Screenshot 2023-10-25 at 12 46 35
Screenshot 2023-10-25 at 12 39 00

After

Screenshot 2023-10-25 at 13 52 33
Screenshot 2023-10-25 at 12 51 15

Related issues

This is part of ongoing tasks related to issue #6887

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer requested a review from a team as a code owner October 25, 2023 13:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer changed the title Refactor/text comp replacement part 4 refactor: [Part 4] - Ongoing Work for legacy <Text> comp replacement. Oct 25, 2023
@Jonathansoufer Jonathansoufer self-assigned this Oct 25, 2023
@Jonathansoufer Jonathansoufer added the team-design-system All issues relating to design system in Mobile label Oct 25, 2023
@Jonathansoufer
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Jonathansoufer Jonathansoufer merged commit 2792959 into main Oct 27, 2023
25 checks passed
@Jonathansoufer Jonathansoufer deleted the refactor/text-comp-replacement-part-4 branch October 27, 2023 09:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants