fix: transactions stuck in submitted status

[matthewwalsh0]

Description

Resolve a bug causing some new transactions to be stuck in the submitted status as they are rejected by the network due to nonce values that are too high.

This is caused by incorrect callbacks in the NonceTracker in the TransactionController, resulting in correct nonce values being skipped because a local confirmed transaction (with the same address but a different chain ID) has the same nonce.

The solution is to update the callbacks used by the NonceTracker to filter transactions to the current chain only.

For a cleaner diff, see this core commit.

Manual testing steps

1. Create a new account.
2. Send some Goerli to the account.
3. Send some Sepolia to the account.
4. Send a transaction on Goerli using the new account.
5. Send a transaction on Sepolia using the new account.
6. Verify both are successful and both using the same nonce.

Recordings

iOS

nonce_ios.mov

Android

nonce.mov

Related issues

Fixes #1304

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sleepytanya]

Transactions with the same nonce values on different networks submitted successfully.
Android build:

nonce.mov

iOS build:

nonce_ios.mov

[matthewwalsh0]

Bitrise Report

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

The base branch was changed.