Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Re-Add decorators to storybook #7416

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Oct 8, 2023

Description

Re-added withNavigation and withSafeArea decorators to storybook

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Oct 8, 2023
@brianacnguyen brianacnguyen self-assigned this Oct 8, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner October 8, 2023 02:23
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (24b4b7e) 34.61% compared to head (0991785) 34.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7416   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files        1017     1017           
  Lines       27162    27162           
  Branches     2211     2211           
=======================================
  Hits         9402     9402           
  Misses      17273    17273           
  Partials      487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@brianacnguyen brianacnguyen changed the title Re-Add decorators to storybook refactor: Re-Add decorators to storybook Oct 10, 2023
@brianacnguyen brianacnguyen merged commit 54a918d into main Oct 10, 2023
@brianacnguyen brianacnguyen deleted the morph/add-decorators branch October 10, 2023 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2023
@metamaskbot metamaskbot added the release-7.10.0 Issue or pull request that will be included in release 7.10.0 label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.10.0 Issue or pull request that will be included in release 7.10.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants