Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert Icon story to csf format #7413

Merged
merged 2 commits into from
Oct 25, 2023
Merged

refactor: Convert Icon story to csf format #7413

merged 2 commits into from
Oct 25, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Convert Icon story to csf format
  • Updated sample consts for icon to include size and color

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-10-07 at 16 58 29
Simulator Screen Shot - iPhone 14 Pro - 2023-10-07 at 16 58 31
Simulator Screen Shot - iPhone 14 Pro - 2023-10-07 at 16 58 33

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Oct 8, 2023
@brianacnguyen brianacnguyen self-assigned this Oct 8, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner October 8, 2023 00:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (55848ab) 34.66% compared to head (593e632) 34.66%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7413   +/-   ##
=======================================
  Coverage   34.66%   34.66%           
=======================================
  Files        1023     1023           
  Lines       27345    27339    -6     
  Branches     2242     2242           
=======================================
  Hits         9478     9478           
+ Misses      17369    17363    -6     
  Partials      498      498
Files Coverage Δ
...nt-library/components/Icons/Icon/Icon.constants.ts 100.00% <ø> (ø)
app/components/Views/BrowserTab/index.js 2.55% <ø> (ø)
app/lib/ens-ipfs/resolver.js 0.00% <ø> (ø)
...ent-library/components/Icons/Icon/Icon.stories.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgewrmarshall
georgewrmarshall previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • pulled branch checked story and controls

.storybook/main.js Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit 3c395f6 into main Oct 25, 2023
25 checks passed
@brianacnguyen brianacnguyen deleted the morph/convert-icons branch October 25, 2023 17:26
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianacnguyen @codecov-commenter @georgewrmarshall @metamaskbot