Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add metrics for Blockaid settings when it's turned on/off #7397

Merged
merged 8 commits into from
Oct 10, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Oct 5, 2023

Description

This PR updates our metric scheme to capture the adoption blockaid security feature so we're able confidently iterate over and improve this feature.

Task

  • Create a new user profile property called security_providers. This property should be a type string property
  • This property should receive the value blockaid if the user has enabled the under Settings > Experimental.
  • If the user turns off the transactions security provider feature under Settings > Experimental, the user profile property security_provider should be updated to remove the blockaid value from it.
  • Whenever the user enables or disables this feature, we should also trigger a new event named Settings Updated with a property security_alerts_enabled with the value true if the user has enabled it or with the value false if user has disabled it.

Issue

Fixes: #6760

References

  1. https://github.com/MetaMask/MetaMask-planning/issues/527

Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/14095680-6f0f-49d1-a1b1-f0ae33330eb7

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@segun segun requested a review from a team as a code owner October 5, 2023 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun changed the title Olu/blockaid settings user metrics2 fix: Olu/blockaid settings user metrics2 Oct 6, 2023
@segun segun changed the title fix: Olu/blockaid settings user metrics2 fix: Add metrics for Blockaid settings when it's turned on/off Oct 6, 2023
segun added 7 commits October 6, 2023 14:38
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@segun segun force-pushed the olu/blockaid-settings-user-metrics2 branch from 9add318 to 8108134 Compare October 6, 2023 13:39
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@segun segun self-assigned this Oct 10, 2023
@segun segun added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team labels Oct 10, 2023
@segun segun merged commit dd2d976 into main Oct 10, 2023
26 of 27 checks passed
@segun segun deleted the olu/blockaid-settings-user-metrics2 branch October 10, 2023 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
@metamaskbot metamaskbot added the release-7.10.0 Issue or pull request that will be included in release 7.10.0 label Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.10.0 Issue or pull request that will be included in release 7.10.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for Blockaid settings when it's turned on/off
4 participants