-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add metrics for Blockaid settings when it's turned on/off #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
segun
changed the title
Olu/blockaid settings user metrics2
fix: Olu/blockaid settings user metrics2
Oct 6, 2023
segun
changed the title
fix: Olu/blockaid settings user metrics2
fix: Add metrics for Blockaid settings when it's turned on/off
Oct 6, 2023
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
segun
force-pushed
the
olu/blockaid-settings-user-metrics2
branch
from
October 6, 2023 13:39
9add318
to
8108134
Compare
Kudos, SonarCloud Quality Gate passed! |
jpuri
approved these changes
Oct 9, 2023
blackdevelopa
approved these changes
Oct 10, 2023
segun
added
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
team-confirmations-secure-ux-PR
PR from the confirmations team
labels
Oct 10, 2023
metamaskbot
added
the
release-7.10.0
Issue or pull request that will be included in release 7.10.0
label
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.10.0
Issue or pull request that will be included in release 7.10.0
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
team-confirmations-secure-ux-PR
PR from the confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our metric scheme to capture the adoption blockaid security feature so we're able confidently iterate over and improve this feature.
Task
security_providers
. This property should be a type string propertyblockaid
if the user has enabled the under Settings > Experimental.security_provider
should be updated to remove theblockaid
value from it.Settings Updated
with a propertysecurity_alerts_enabled
with the valuetrue
if the user has enabled it or with the valuefalse
if user has disabled it.Issue
Fixes: #6760
References
Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/14095680-6f0f-49d1-a1b1-f0ae33330eb7
Checklist