Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ramp): refactor get started copy #7390

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 4, 2023

Description

This PR refactors the copy in the Get Started welcome view of the Buy flow

Manual testing steps

  1. With a fresh install confirm the copy changes when opening the Buy flow

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

After

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Oct 4, 2023
@wachunei wachunei requested a review from a team as a code owner October 4, 2023 22:55
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8636b3e) 34.59% compared to head (14e6bda) 34.62%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7390      +/-   ##
==========================================
+ Coverage   34.59%   34.62%   +0.02%     
==========================================
  Files        1017     1017              
  Lines       27150    27157       +7     
  Branches     2211     2215       +4     
==========================================
+ Hits         9393     9402       +9     
+ Misses      17268    17265       -3     
- Partials      489      490       +1     
Files Coverage Δ
...components/UI/Ramp/Views/GetStarted/GetStarted.tsx 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 5, 2023
@wachunei wachunei merged commit 24b4b7e into main Oct 5, 2023
25 checks passed
@wachunei wachunei deleted the refactor/ramp-buy-get-started-copy branch October 5, 2023 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
@metamaskbot metamaskbot added the release-7.10.0 Issue or pull request that will be included in release 7.10.0 label Oct 5, 2023
@hesterbruikman hesterbruikman added release-7.9.0 Issue or pull request that will be included in release 7.9.0 and removed release-7.10.0 Issue or pull request that will be included in release 7.10.0 labels Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-ramp-qa Tickets that need feature QA on the ramps flows release-7.9.0 Issue or pull request that will be included in release 7.9.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants