refactor: Convert Avatar stories to csf format

[brianacnguyen]

Description

• Updated Avatar Base's const, stories, and test files.
• Updated Avatar Account's const, stories, and test files.
• Updated Avatar Favicon's const, stories, and test files.
• Updated Avatar Icon's const, stories, and test files.
• Updated Avatar Network's const, stories, and test files.
• Updated Avatar Token's const, stories, and test files.

Screenshots/Recordings

after.mov

Related issues

Fixes #???

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

Looking good. Left some comments. This PR is quite large and addresses several issues that could potentially be split into multiple PRs. To make it easier on the reviewer I would suggest breaking up PRs like this in future. Pulled branch and checked

• for any remaining references to AvatarVariants to ensure none were overlooked.
• stories, controls and console

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d3586f7-8653-4e01-9565-2e91d6ad95b0
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[codecov-commenter]

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (3e5c9da) 34.98% compared to head (0a442ff) 35.06%.

Files	Patch %	Lines
...brary/components/Avatars/Avatar/Avatar.stories.tsx	0.00%	9 Missing ⚠️
...r/variants/AvatarFavicon/AvatarFavicon.stories.tsx	0.00%	3 Missing ⚠️
...r/variants/AvatarNetwork/AvatarNetwork.stories.tsx	0.00%	3 Missing ⚠️
...vatar/variants/AvatarToken/AvatarToken.stories.tsx	0.00%	3 Missing ⚠️
...onent-library/components/Avatars/Avatar/Avatar.tsx	71.42%	1 Missing and 1 partial ⚠️
...r/variants/AvatarAccount/AvatarAccount.stories.tsx	0.00%	2 Missing ⚠️
.../Avatar/variants/AvatarIcon/AvatarIcon.stories.tsx	0.00%	2 Missing ⚠️
.../Avatars/Avatar/variants/AvatarIcon/AvatarIcon.tsx	50.00%	1 Missing and 1 partial ⚠️
...rs/Avatar/variants/AvatarAccount/AvatarAccount.tsx	50.00%	1 Missing ⚠️
...rs/Avatar/variants/AvatarFavicon/AvatarFavicon.tsx	66.66%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7374      +/-   ##
==========================================
+ Coverage   34.98%   35.06%   +0.08%     
==========================================
  Files        1040     1040              
  Lines       27690    27669      -21     
  Branches     2345     2345              
==========================================
+ Hits         9686     9702      +16     
+ Misses      17480    17442      -38     
- Partials      524      525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[georgewrmarshall]

Running into some issues

• Avatar variant favicon is square is that intentional?
• Error on Avatar variant token

Screen.Recording.2023-11-10.at.11.49.32.AM.mov

[brianacnguyen]

Running into some issues

• Avatar variant favicon is square is that intentional?
• Error on Avatar variant token

Screen.Recording.2023-11-10.at.11.49.32.AM.mov

fixed

[georgewrmarshall]

Stories are working but looks like you have some failing tests. This is the video I would like to see as a reviewer to see that you have also checked all the stories. Keep in mind the more stories you add the more that need to be QA'd I would expect these to be checked by the author first. This will also help for faster review

after.mov

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

1 Bug
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

65.8% Coverage
0.0% Duplication