-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependency patch on SignatureController
#7355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
changed the title
Remove unnecessary dependency patch on signature controller
Remove unnecessary dependency patch on Sep 29, 2023
SignatureController
OGPoyraz
added
the
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
label
Sep 29, 2023
OGPoyraz
force-pushed
the
remove-signature-controller-dependency-patch
branch
from
September 29, 2023 09:01
be29669
to
50342e1
Compare
vinistevam
previously approved these changes
Sep 29, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7355 +/- ##
==========================================
- Coverage 34.60% 34.59% -0.01%
==========================================
Files 1017 1017
Lines 27144 27150 +6
Branches 2205 2211 +6
==========================================
Hits 9393 9393
- Misses 17262 17268 +6
Partials 489 489 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
matthewwalsh0
approved these changes
Oct 11, 2023
metamaskbot
added
the
release-7.10.0
Issue or pull request that will be included in release 7.10.0
label
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-7.10.0
Issue or pull request that will be included in release 7.10.0
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to remove unnecessary dependency patch in
SignatureController
(message-manager
patch) and makeSignatureController@4.0.1
patch a bit cleaner by putting a comment (which branch patch created from) and remove unnecessary changes.Why
message-manager
patch is removed?Since
controller-utils
is updated in to3.4.0
in mobile repo, the patch made in themessage-manager
is became unnecessary because patched imports already been exported in3.4.0
.What changed in the
signature-controller
patch?Same exported enums were needed in the
signature-controller
, so these patches are removed.Also put a comment of how can we reproduce
signature-controller
patch if needed. https://github.com/MetaMask/core/tree/patch/mobile-signature-controllerManual testing steps
No functional change here.
But it's still beneficial to run regression tests around signatures.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change.
Before
[screenshot]
After
[screenshot]
Related issues
Fixes #???
Pre-merge author checklist
Pre-merge reviewer checklist