fix: Fix TS errors in core directory
#7331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Cal-L
added
the
needs-dev-review
…to fix/6949-ts-errors-in-core
gauthierpetetin
added
in-progress
and removed
needs-dev-review
gauthierpetetin
added
needs-dev-review
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7331 +/- ##
=======================================
Coverage 34.59% 34.60%
=======================================
Files 1019 1019
Lines 27192 27193 +1
Branches 2212 2212
=======================================
+ Hits 9408 9409 +1
Misses 17296 17296
Partials 488 488
☔ View full report in Codecov by Sentry. |
Cal-L
force-pushed
the
fix/6949-ts-errors-in-core
branch
from
de6a9a3 to
2c351f8
Compare
…to fix/6949-ts-errors-in-core
|
Kudos, SonarCloud Quality Gate passed! |
Cal-L
added
the
No QA Needed
frankvonhoven
approved these changes
Oct 10, 2023
Cal-L
removed
the
needs-dev-review
metamaskbot
added
the
release-7.10.0
gauthierpetetin
added
team-mobile-platform
team-mobile-ux
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the rest of the pre-existing TS errors in the
coredirectory. We also updatedtsconfig.lint.jsonto prevent the introduction of new Typescript errors incoredirectory moving forward. Since tslint is enabled for the CI, all green tests should indicate that there are no longer TS errors incore.Passing E2E smoke tests - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f6c04d9-961b-4827-adf3-ed3a93024613