-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: finding and updating transaction errors in confirmation pages state #7319
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7319 +/- ##
==========================================
+ Coverage 34.59% 34.60% +0.01%
==========================================
Files 1017 1017
Lines 27150 27162 +12
Branches 2211 2211
==========================================
+ Hits 9393 9400 +7
- Misses 17268 17275 +7
+ Partials 489 487 -2
☔ View full report in Codecov by Sentry. |
e508bcd
to
63607cf
Compare
I've started a Bitrise e2e run here, to check if successful when finishes: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e811b91a-e6f0-4746-85c5-11e77f602fa3 |
Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>
Kudos, SonarCloud Quality Gate passed! |
Description
The PR fixes the issue - whenever loading balance is delayed, the Warning for needing more ETH is displayed and cannot perform the tx once the balance is loaded.
The reason for this issue was wrong state update for error, I fixed this but re-calculating error every time transaction / user balance / contracts balance changes. Thus as soon as balance is fetched the error goes away.
Manual testing steps
Related issues
_Fixes #6535
Pre-merge author checklist
Pre-merge reviewer checklist