Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transaction controller patch #7314

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix: transaction controller patch #7314

merged 2 commits into from
Sep 26, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Sep 25, 2023 •
edited
Loading

Description

The fix: legacy gas fee edit modal PR introduced changes to the monorepo and wasn't patched properly. This PR fixes that. Context

Fixes #???
#7035 (comment)

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa changed the title fix the transaction controller patch fix: transaction controller patch Sep 25, 2023
@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Sep 25, 2023
@blackdevelopa blackdevelopa marked this pull request as ready for review September 25, 2023 09:48
@blackdevelopa blackdevelopa requested a review from a team as a code owner September 25, 2023 09:48
jpuri
jpuri approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (0afaaa8) 34.60% compared to head (c41dd3c) 34.60%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7314   +/-   ##
=======================================
  Coverage   34.60%   34.60%           
=======================================
  Files        1016     1016           
  Lines       27107    27107           
  Branches     2198     2198           
=======================================
  Hits         9381     9381           
  Misses      17237    17237           
  Partials      489      489

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackdevelopa blackdevelopa mentioned this pull request Sep 25, 2023
Merged
7 tasks
Gudahtt
Gudahtt approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Member

Gudahtt commented Sep 25, 2023

Passing E2E smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f7b1a43-b929-48d8-8f54-6ed5154588ec

@Gudahtt Gudahtt added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 25, 2023
@blackdevelopa blackdevelopa removed the request for review from matthewwalsh0 September 26, 2023 13:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blackdevelopa blackdevelopa merged commit 3fa6545 into main Sep 26, 2023
@blackdevelopa blackdevelopa deleted the core/transaction_patch_fix branch September 26, 2023 13:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
@metamaskbot metamaskbot added the release-7.9.0 Issue or pull request that will be included in release 7.9.0 label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@jpuri jpuri jpuri approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.9.0 Issue or pull request that will be included in release 7.9.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blackdevelopa @codecov-commenter @Gudahtt @jpuri @metamaskbot