-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase Confirmations e2e stability by terminating ganache on hooks #7287
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7287 +/- ##
=======================================
Coverage 34.43% 34.43%
=======================================
Files 1016 1016
Lines 27089 27089
Branches 2206 2206
=======================================
Hits 9329 9329
Misses 17267 17267
Partials 493 493 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
Description
It has been observed that in some Android runs, relative to confirmations, tests were sometimes flaky due to Ganache not terminating properly.
This was not evident on regular runs as only Smoke tests are run (with 1 test using ganache) but it shines in the case you run all the Confirmations e2e (more than 1 test using ganache, needing the server to terminate and start everytime).
(Context)
This change increase confirmations e2e stability by terminating the ganache server in the
afterEach
hooks instead of inside thewithFixtures
method.Manual testing steps
Screenshots/Recordings
Before
Intermittent Android failures
After
All runs are passing now in Android
Related issues
Pre-merge author checklist
Pre-merge reviewer checklist