Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 5.8.1 Sentry SDK Upgrade #7277

Merged
merged 8 commits into from
Sep 28, 2023
Merged

chore: 5.8.1 Sentry SDK Upgrade #7277

merged 8 commits into from
Sep 28, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Sep 20, 2023

Description

This PR bumps the Sentry SDK version to from 5.1.0 -> 5.8.1. The minor version bumps did not have any breaking changes per documentation.

Manual testing steps

Run the app and observe any errors reporting in Sentry

Screenshots/Recordings

Passing E2E Testing

Related issues

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. release-7.9.0 Issue or pull request that will be included in release 7.9.0 labels Sep 20, 2023
@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 20, 2023
@sethkfman sethkfman marked this pull request as ready for review September 20, 2023 22:22
@sethkfman sethkfman requested a review from a team as a code owner September 20, 2023 22:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (481412d) 34.60% compared to head (3875abc) 34.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7277   +/-   ##
=======================================
  Coverage   34.60%   34.60%           
=======================================
  Files        1017     1017           
  Lines       27104    27104           
  Branches     2197     2197           
=======================================
  Hits         9379     9379           
  Misses      17236    17236           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@sentry/react-native 5.1.1...5.8.1 None +11/-10 7.63 MB sentry-bot

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sethkfman sethkfman merged commit 2f339b7 into main Sep 28, 2023
@sethkfman sethkfman deleted the chore/sentry-upgrade branch September 28, 2023 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.9.0 Issue or pull request that will be included in release 7.9.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants