Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signature event names #7271

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: signature event names #7271

merged 1 commit into from
Sep 26, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Sep 19, 2023

Description

This PR fixes signature event names, but about three instances were missed. This PR fixes the missed instances.

Related issues

Fixes: 1127

##References
Signature events documentation in the segment schema repo: https://github.com/ConsenSys/segment-schema/tree/main/libraries/events/metamask-transactions

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b38039f9-89bc-4a80-8410-6fe017106714

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team labels Sep 19, 2023
@segun segun self-assigned this Sep 19, 2023
@segun segun requested a review from a team as a code owner September 19, 2023 17:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun changed the title Fix signature event names fix: signature event names Sep 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@segun segun merged commit bb938ea into main Sep 26, 2023
@segun segun deleted the olu/fix-signature-event-names branch September 26, 2023 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 26, 2023
@metamaskbot metamaskbot added the release-7.9.0 Issue or pull request that will be included in release 7.9.0 label Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.9.0 Issue or pull request that will be included in release 7.9.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants