feat: extend the time we resume the session without showing OTP #7212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
omridan159
commented
Sep 14, 2023
abretonc7s
previously approved these changes
Sep 14, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7212 +/- ##
==========================================
- Coverage 34.60% 34.57% -0.04%
==========================================
Files 1017 1017
Lines 27104 27125 +21
Branches 2197 2204 +7
==========================================
- Hits 9379 9378 -1
- Misses 17236 17258 +22
Partials 489 489
☔ View full report in Codecov by Sentry. |
omridan159
commented
Sep 14, 2023
omridan159
commented
Sep 14, 2023
omridan159
commented
Sep 14, 2023
andreahaku
added
needs-dev-review
|
I have read the CLA Document and I hereby sign the CLA |
omridan159
added
the
needs-qa
abretonc7s
force-pushed
the
feat_updating-OTP-flow
branch
from
79c9ba3 to
d6f7931
Compare
abretonc7s
previously approved these changes
Sep 18, 2023
…t_updating-OTP-flow
abretonc7s
force-pushed
the
feat_updating-OTP-flow
branch
from
f9657c0 to
d3e36e3
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
christopherferreira9
added
QA in Progress
|
Kudos, SonarCloud Quality Gate passed! |
christopherferreira9
added
QA Passed
metamaskbot
added
the
release-7.9.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
Extended the session persistence time to one hour without showing OTP.
For the first hour after connecting, the session will remain active without requesting an OTP.
All of the examples SDK apps that use the OTP modal tested on IOS and Android with a new wallet build that includes the new OTP changes.
The cases that have been checked were
when the channel was active recentlyandwhen the channel was NOT active recentlyin order to test both flows.Everything appears to be working as expected.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
fixes #???
Checklist