Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Jest to v29 #7160

Closed
wants to merge 1 commit into from
Closed

chore: Update Jest to v29 #7160

wants to merge 1 commit into from

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 7, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add the appropiate QA label when dev review is completed
    • needs-qa: PR requires manual QA.
    • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
    • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
  6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

Jest has been updated to v29, along with related dependencies. This change comes with a number of new features, such as the new jest.replaceProperty() function.

The only breaking change affecting us is a change to the snapshot format. All snapshots have been updated.

See here for the migration guide: https://jest-archive-august-2023.netlify.app/docs/upgrading-to-jest29/

See here for a full list of changes: https://github.com/jestjs/jest/blob/main/CHANGELOG.md#2900

Issue

No directly related issue, but I started this because the new jest.replaceProperty() function would be really useful in testing changes related to the upcoming controller updates.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@socket-security
Copy link

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/jest 28.1.8...29.5.4 None +2/-0 161 kB types

🚮 Removed packages: babel-jest@28.1.3, jest@28.1.3

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (31744a1) 33.02% compared to head (49623bf) 33.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7160   +/-   ##
=======================================
  Coverage   33.02%   33.02%           
=======================================
  Files        1004     1004           
  Lines       26888    26888           
  Branches     2131     2131           
=======================================
  Hits         8881     8881           
  Misses      17571    17571           
  Partials      436      436           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt marked this pull request as ready for review September 7, 2023 12:50
@Gudahtt Gudahtt requested a review from a team as a code owner September 7, 2023 12:50
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 7, 2023
@Gudahtt Gudahtt force-pushed the update-jest-to-v29 branch 6 times, most recently from 7220373 to 1da7c43 Compare September 14, 2023 02:23
Jest has been updated to v29, along with related dependencies. This
change comes with a number of new features, such as the new
`jest.replaceProperty()` function.

The only breaking change affecting us is a change to the snapshot
format. All snapshots have been updated.

See here for the migration guide: https://jest-archive-august-2023.netlify.app/docs/upgrading-to-jest29/

See here for a full list of changes: https://github.com/jestjs/jest/blob/main/CHANGELOG.md#2900
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some snapshots will need refreshing after rebasing on main, LGTM otherwise!

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added stale Issues that have not had activity in the last 90 days and removed stale Issues that have not had activity in the last 90 days labels Dec 20, 2023
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 8, 2024
@metamaskbot metamaskbot added product-backlog and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 23, 2024
@Gudahtt Gudahtt marked this pull request as draft March 5, 2024 16:36
@Gudahtt
Copy link
Member Author

Gudahtt commented May 1, 2024

Replaced by #9454

@Gudahtt Gudahtt closed this May 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants