-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Jest to v29 #7160
Conversation
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: babel-jest@28.1.3, jest@28.1.3 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7160 +/- ##
=======================================
Coverage 33.02% 33.02%
=======================================
Files 1004 1004
Lines 26888 26888
Branches 2131 2131
=======================================
Hits 8881 8881
Misses 17571 17571
Partials 436 436 ☔ View full report in Codecov by Sentry. |
7220373
to
1da7c43
Compare
Jest has been updated to v29, along with related dependencies. This change comes with a number of new features, such as the new `jest.replaceProperty()` function. The only breaking change affecting us is a change to the snapshot format. All snapshots have been updated. See here for the migration guide: https://jest-archive-august-2023.netlify.app/docs/upgrading-to-jest29/ See here for a full list of changes: https://github.com/jestjs/jest/blob/main/CHANGELOG.md#2900
1da7c43
to
49623bf
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some snapshots will need refreshing after rebasing on main, LGTM otherwise!
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
Replaced by #9454 |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
: PR requires manual QA.No QA/E2E only
: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build
: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passed
label when QA has signed off (Only required if the PR was labeled withneeds-qa
)team-
(orexternal-contributor
label if your not a MetaMask employee)Description
Jest has been updated to v29, along with related dependencies. This change comes with a number of new features, such as the new
jest.replaceProperty()
function.The only breaking change affecting us is a change to the snapshot format. All snapshots have been updated.
See here for the migration guide: https://jest-archive-august-2023.netlify.app/docs/upgrading-to-jest29/
See here for a full list of changes: https://github.com/jestjs/jest/blob/main/CHANGELOG.md#2900
Issue
No directly related issue, but I started this because the new
jest.replaceProperty()
function would be really useful in testing changes related to the upcoming controller updates.Checklist