refactor: Refactor isTestNet to accept chain ID
#7156
Merged
+49
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
needs-dev-review
Gudahtt
force-pushed
the
refactor-is-testnet
branch
from
a805805 to
f26746e
Compare
Gudahtt
force-pushed
the
refactor-is-testnet
branch
from
f26746e to
e4ed547
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7156 +/- ##
==========================================
- Coverage 32.84% 32.83% -0.01%
==========================================
Files 1006 1006
Lines 32731 32727 -4
Branches 8399 8396 -3
==========================================
- Hits 10749 10745 -4
Misses 21982 21982
☔ View full report in Codecov by Sentry. |
|
Passing E2E smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/973063bf-1e8a-473f-8f41-a64a06f64235 |
The `isTestNet` utility function now accepts a chain ID rather than a network ID. The chain ID is easier for us to access because we know the chain ID for all networks statically, as it's a required network configuration property. The network ID on the other hand is looked up at runtime, and is sometimes not present. In practice we had already been passing in chain ID as network ID in many places This hasn't caused issues because they are equivalent for most (though not all) networks. This relates to MetaMask/mobile-planning#1226
This snapshot wasn't expected to change, but it seems to have been affected due to invalid test fixtures which had been missing the network ID.
Gudahtt
force-pushed
the
refactor-is-testnet
branch
from
c1d0708 to
4f7ae41
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Gudahtt
added
No QA Needed
|
Applying the E2E only test case because the scope of this change is quite small, and the affected area is covered by some E2E tests (e.g. the |
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
The
isTestNetutility function now accepts a chain ID rather than a network ID. The chain ID is easier for us to access because we know the chain ID for all networks statically, as it's a required network configuration property. The network ID on the other hand is looked up at runtime, and is sometimes not present.In practice we had already been passing in chain ID as network ID in many places. This hasn't caused issues because they are equivalent for most (though not all) networks.
Issue
This relates to https://github.com/MetaMask/mobile-planning/issues/1226
Checklist