-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add depcheck test #7124
ci: Add depcheck test #7124
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore-all The unmaintained packages have no clear alternatives. The "new authors" are for versions ~6 years old. The one package with filesystem access is supposed to have filesystem access ( |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7124 +/- ##
=======================================
Coverage 32.83% 32.83%
=======================================
Files 1006 1006
Lines 32727 32727
Branches 8396 8396
=======================================
Hits 10745 10745
Misses 21982 21982 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
720b6fe
to
bb7e5e3
Compare
2881991
to
f0d15e3
Compare
A test has been added to CI to ensure we don't accidentally leave packages in our manifest that aren't used, or forget to list packages in our mainfest. We have a large number of seemingly unused or missing dependencies at the moment. Rather than fixing them all at once, they have been temporarily ignored. This lets us stop the problem from getting worse without delay. Each ignored dependency will be addressed in a later PR.
f0d15e3
to
44f43a4
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
: PR requires manual QA.No QA/E2E only
: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build
: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passed
label when QA has signed off (Only required if the PR was labeled withneeds-qa
)team-
(orexternal-contributor
label if your not a MetaMask employee)Description
A test has been added to CI to ensure we don't accidentally leave packages in our manifest that aren't used, or forget to list packages in our mainfest.
We have a large number of seemingly unused or missing dependencies at the moment. Rather than fixing them all at once, they have been temporarily ignored. This lets us stop the problem from getting worse without delay. Each ignored dependency will be addressed in a later PR.
Issue
No related issue
Checklist