ci: Add type check lint to CI #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
added
needs-dev-review
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7100 +/- ##
=======================================
Coverage 32.86% 32.86%
=======================================
Files 1001 1001
Lines 26743 26743
Branches 2101 2101
=======================================
Hits 8788 8788
Misses 17535 17535
Partials 420 420 ☔ View full report in Codecov by Sentry. |
Gudahtt
added
the
No QA Needed
A new `lint:tsc` command has been added to validate TypeScript types in the project. This lint command uses a separate configuration, `tsconfig.lint.ts`, which covers just the files that have no type errors. We can expand the type check coverage over time as we fix more type errors. One additional change was made to fix a TypeScript error that hade an impact on many files. The problem was caused by a TypeScript bug that causes the compiler to fail when it encounters certain unicode characters. Those characters were in a JSON file in the `unicode-confusables` package. They have been temporarily removed until this TypeScript error can be fixed. For more details, see microsoft/TypeScript#53519
Gudahtt
force-pushed
the
add-type-check-lint-script
branch
from
f4a7696 to
fae7e29
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
A new
lint:tsccommand has been added to validate TypeScript types in the project. This lint command uses a separate configuration,tsconfig.lint.ts, which covers just the files that have no type errors. We can expand the type check coverage over time as we fix more type errors.One additional change was made to fix a TypeScript error that hade an impact on many files. The problem was caused by a TypeScript bug that causes the compiler to fail when it encounters certain unicode characters. Those characters were in a JSON file in the
unicode-confusablespackage. They have been temporarily removed until this TypeScript error can be fixed.For more details, see microsoft/TypeScript#53519
Issue
No related issue
Checklist