Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: incoming transactions translations #7075

Merged
merged 1 commit into from
Aug 29, 2023
Merged

feat: incoming transactions translations #7075

merged 1 commit into from
Aug 29, 2023

Conversation

tommasini
Copy link
Contributor

Description
image

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client release-7.7.0 Issue or pull request that will be included in release 7.7.0 labels Aug 29, 2023
@tommasini tommasini requested a review from a team as a code owner August 29, 2023 14:04
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

Merging #7075 (6cc724b) into main (c785d3d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7075   +/-   ##
=======================================
  Coverage   32.82%   32.82%           
=======================================
  Files         998      998           
  Lines       26671    26671           
  Branches     2091     2091           
=======================================
  Hits         8755     8755           
  Misses      17498    17498           
  Partials      418      418

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tommasini tommasini merged commit 5dd296c into main Aug 29, 2023
@tommasini tommasini deleted the translations/1188-incoming-transactions branch August 29, 2023 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 29, 2023
@gauthierpetetin gauthierpetetin added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Sep 4, 2023
@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. in-progress labels Sep 12, 2023
@gauthierpetetin gauthierpetetin added issues-found needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. issues-found labels Sep 25, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-7.7.0 Issue or pull request that will be included in release 7.7.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @codecov-commenter @NicolasMassart @gauthierpetetin