-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ramp): upgrade sdk to 1.23.0 #7054
Conversation
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
aceac4c
to
2a32f3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @wachunei could you add the change log url of the version 1.23 on the description?
@wachunei LGTM I finished verifying this change |
We don't have a public source code with a changelog to link to 😬 |
Codecov Report
@@ Coverage Diff @@
## main #7054 +/- ##
=======================================
Coverage 32.83% 32.83%
=======================================
Files 998 998
Lines 26665 26665
Branches 2091 2091
=======================================
Hits 8756 8756
Misses 17491 17491
Partials 418 418 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
: PR requires manual QA.No QA/E2E only
: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build
: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passed
label when QA has signed off (Only required if the PR was labeled withneeds-qa
)team-
(orexternal-contributor
label if your not a MetaMask employee)Description
This PR upgrades
@consensys/on-ramp-sdk
to version1.23.0
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
fixes #???
Checklist