Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): upgrade sdk to 1.23.0 #7054

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Aug 24, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add the appropiate QA label when dev review is completed
    • needs-qa: PR requires manual QA.
    • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
    • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
  6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

This PR upgrades @consensys/on-ramp-sdk to version 1.23.0

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 24, 2023
@wachunei wachunei requested a review from a team as a code owner August 24, 2023 15:28
@wachunei wachunei added team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Aug 24, 2023
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@consensys/on-ramp-sdk 1.22.0...1.23.0 None +0/-0 389 kB pmkowalski

@wachunei wachunei force-pushed the chore/ramp-upgrade-sdk-1.23.0 branch from aceac4c to 2a32f3b Compare August 24, 2023 16:36
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @wachunei could you add the change log url of the version 1.23 on the description?

@bkirb
Copy link
Contributor

bkirb commented Aug 25, 2023

@wachunei LGTM I finished verifying this change

@wachunei
Copy link
Member Author

LGTM, @wachunei could you add the change log url of the version 1.23 on the description?

We don't have a public source code with a changelog to link to 😬

@wachunei wachunei added ramp-qa-passed and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Aug 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7054 (446a079) into main (9cdb221) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #7054   +/-   ##
=======================================
  Coverage   32.83%   32.83%           
=======================================
  Files         998      998           
  Lines       26665    26665           
  Branches     2091     2091           
=======================================
  Hits         8756     8756           
  Misses      17491    17491           
  Partials      418      418           

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@wachunei wachunei merged commit d2d898c into main Aug 25, 2023
@wachunei wachunei deleted the chore/ramp-upgrade-sdk-1.23.0 branch August 25, 2023 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
@metamaskbot metamaskbot added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ramp-qa-passed release-7.7.0 Issue or pull request that will be included in release 7.7.0 team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants