Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: @lavamoat/allow-scripts@1.0.6->2.3.1 #7032

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

legobeat
Copy link
Contributor

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat changed the title Devdeps lavamoat allow scripts devDeps: @lavamoat/allow-scripts@1.0.6->2.3.1 Aug 22, 2023
@legobeat legobeat requested a review from leotm August 22, 2023 09:21
@legobeat legobeat marked this pull request as ready for review August 22, 2023 09:21
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from add999e to fd82f9b Compare August 22, 2023 09:21
@legobeat legobeat requested a review from a team as a code owner August 22, 2023 09:21
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@lavamoat/allow-scripts 1.0.6...2.3.1 network, filesystem, shell, environment +42/-9 3.41 MB lgbot
@wdio/appium-service 7.31.1...7.32.0 None +0/-0 19 kB wdio-user

@socket-security
Copy link

socket-security bot commented Aug 22, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @lavamoat/allow-scripts@2.3.1, json-parse-even-better-errors@3.0.0, unique-slug@3.0.0, @npmcli/node-gyp@3.0.0, read-cmd-shim@4.0.0, @npmcli/run-script@6.0.1, npm-normalize-package-bin@3.0.1, write-file-atomic@5.0.1, @npmcli/fs@2.1.2, nopt@6.0.0, smart-buffer@4.2.0, @tootallnate/once@2.0.0, minipass-sized@1.0.3, err-code@2.0.3, promise-retry@2.0.1, minipass-flush@1.0.5, humanize-ms@1.2.1, @gar/promisify@1.1.3, minipass-pipeline@1.2.4, promise-inflight@1.0.1, is-lambda@1.0.1, make-fetch-happen@10.2.1, minipass-fetch@2.1.2, cacache@16.1.3, bin-links@4.0.1, @lavamoat/aa@3.1.2

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @lavamoat/allow-scripts@2.3.1
@SocketSecurity ignore json-parse-even-better-errors@3.0.0
@SocketSecurity ignore unique-slug@3.0.0
@SocketSecurity ignore @npmcli/node-gyp@3.0.0
@SocketSecurity ignore read-cmd-shim@4.0.0
@SocketSecurity ignore @npmcli/run-script@6.0.1
@SocketSecurity ignore npm-normalize-package-bin@3.0.1
@SocketSecurity ignore write-file-atomic@5.0.1
@SocketSecurity ignore @npmcli/fs@2.1.2
@SocketSecurity ignore nopt@6.0.0
@SocketSecurity ignore smart-buffer@4.2.0
@SocketSecurity ignore @tootallnate/once@2.0.0
@SocketSecurity ignore minipass-sized@1.0.3
@SocketSecurity ignore err-code@2.0.3
@SocketSecurity ignore promise-retry@2.0.1
@SocketSecurity ignore minipass-flush@1.0.5
@SocketSecurity ignore humanize-ms@1.2.1
@SocketSecurity ignore @gar/promisify@1.1.3
@SocketSecurity ignore minipass-pipeline@1.2.4
@SocketSecurity ignore promise-inflight@1.0.1
@SocketSecurity ignore is-lambda@1.0.1
@SocketSecurity ignore make-fetch-happen@10.2.1
@SocketSecurity ignore minipass-fetch@2.1.2
@SocketSecurity ignore cacache@16.1.3
@SocketSecurity ignore bin-links@4.0.1
@SocketSecurity ignore @lavamoat/aa@3.1.2

@legobeat legobeat added dependencies Pull requests that update a dependency file type-security labels Aug 22, 2023
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from fd82f9b to c7bd6fb Compare August 28, 2023 01:29
@legobeat legobeat requested a review from Cal-L August 28, 2023 01:30
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from c7bd6fb to ed53e4c Compare September 1, 2023 01:55
@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from ed53e4c to c38660b Compare September 4, 2023 09:47
Copy link
Member

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 only one suggestion RE Sentry


nb: Storybook testing depends on

where we'll enable lifecycle scripts if/as needed

package.json Show resolved Hide resolved
@leotm
Copy link
Member

leotm commented Sep 4, 2023

@SocketSecurity ignore @lavamoat/allow-scripts@2.3.1
@SocketSecurity ignore json-parse-even-better-errors@3.0.0
@SocketSecurity ignore unique-slug@3.0.0
@SocketSecurity ignore @npmcli/node-gyp@3.0.0
@SocketSecurity ignore read-cmd-shim@4.0.0
@SocketSecurity ignore @npmcli/run-script@6.0.1
@SocketSecurity ignore npm-normalize-package-bin@3.0.1
@SocketSecurity ignore write-file-atomic@5.0.1
@SocketSecurity ignore @npmcli/fs@2.1.2
@SocketSecurity ignore nopt@6.0.0
@SocketSecurity ignore smart-buffer@4.2.0
@SocketSecurity ignore @tootallnate/once@2.0.0
@SocketSecurity ignore minipass-sized@1.0.3
@SocketSecurity ignore err-code@2.0.3
@SocketSecurity ignore promise-retry@2.0.1
@SocketSecurity ignore minipass-flush@1.0.5
@SocketSecurity ignore humanize-ms@1.2.1
@SocketSecurity ignore @gar/promisify@1.1.3
@SocketSecurity ignore minipass-pipeline@1.2.4
@SocketSecurity ignore promise-inflight@1.0.1
@SocketSecurity ignore is-lambda@1.0.1
@SocketSecurity ignore make-fetch-happen@10.2.1
@SocketSecurity ignore minipass-fetch@2.1.2
@SocketSecurity ignore cacache@16.1.3
@SocketSecurity ignore bin-links@4.0.1
@SocketSecurity ignore @lavamoat/aa@3.1.2

nit: do you have a link to the prev report? curious to see the Socket Security issues on these deps

@legobeat legobeat requested a review from leotm September 7, 2023 06:28
@leotm
Copy link
Member

leotm commented Sep 7, 2023

new yarn.lock conflict remaining then good 2 go!

@legobeat legobeat force-pushed the devdeps-lavamoat-allow-scripts branch from 3506e66 to 663465f Compare September 7, 2023 08:04
@legobeat
Copy link
Contributor Author

legobeat commented Sep 7, 2023

[...]

nit: do you have a link to the prev report? curious to see the Socket Security issues on these deps

Best I got is to click the "edited" link in the header of the comment.

@legobeat legobeat mentioned this pull request Sep 7, 2023
3 tasks
@sethkfman sethkfman merged commit 512743f into MetaMask:main Sep 7, 2023
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
@legobeat legobeat deleted the devdeps-lavamoat-allow-scripts branch September 7, 2023 21:17
@legobeat legobeat restored the devdeps-lavamoat-allow-scripts branch May 21, 2024 04:34
@legobeat legobeat deleted the devdeps-lavamoat-allow-scripts branch May 21, 2024 04:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file team-lavamoat type-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants