Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ipfs implementation #6968

Merged
merged 18 commits into from
Aug 23, 2023
Merged

feat: Ipfs implementation #6968

merged 18 commits into from
Aug 23, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Aug 3, 2023 •
edited by Cal-L
Loading

Description
More info here
Videos are attached to the link above

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title CollectibleMedia and Security settings comps to TS, ipfs logic added Feat: Ipfs implementation Aug 3, 2023
@tommasini tommasini changed the title Feat: Ipfs implementation feat: Ipfs implementation Aug 3, 2023
@tommasini tommasini marked this pull request as ready for review August 4, 2023 11:17
@tommasini tommasini requested a review from a team as a code owner August 4, 2023 11:17
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-7.6.0 Issue or pull request that will be included in release 7.6.0 labels Aug 4, 2023
@gauthierpetetin gauthierpetetin added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) in-progress labels Aug 4, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6968 (149a734) into main (2326d87) will increase coverage by 0.84%.
The diff coverage is 52.07%.

@@            Coverage Diff             @@
##             main    #6968      +/-   ##
==========================================
+ Coverage   32.86%   33.70%   +0.84%     
==========================================
  Files         994      999       +5     
  Lines       26472    26562      +90     
  Branches     2061     2111      +50     
==========================================
+ Hits         8699     8954     +255     
+ Misses      17359    17155     -204     
- Partials      414      453      +39
Files Changed Coverage Δ
app/components/UI/ActionView/index.js 62.50% <ø> (ø)
app/components/UI/AddCustomCollectible/index.tsx 2.32% <0.00%> (-0.21%) ⬇️
app/components/UI/CollectibleContracts/index.js 6.75% <0.00%> (-1.18%) ⬇️
.../components/UI/CollectibleDetectionModal/index.tsx 40.00% <ø> (ø)
...nents/UI/CollectibleMedia/Collectible.constants.ts 0.00% <0.00%> (ø)
app/components/UI/TokenImage/index.js 44.44% <0.00%> (-12.70%) ⬇️
app/components/Views/BrowserTab/index.js 2.66% <0.00%> (-0.02%) ⬇️
...gs/SecuritySettings/Sections/AutoLock/AutoLock.tsx 85.71% <ø> (+71.42%) ⬆️
...itySettings/Sections/ClearPrivacy/ClearPrivacy.tsx 53.84% <ø> (+46.15%) ⬆️
...ecuritySettings/Sections/DeleteMetaMetricsData.tsx 47.91% <ø> (+43.75%) ⬆️
... and 18 more

... and 17 files with indirect coverage changes

sethkfman
sethkfman previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sethkfman
sethkfman approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini changed the base branch from main to feat/824-batch August 17, 2023 19:23
@gauthierpetetin gauthierpetetin added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

55.4% 55.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@tommasini tommasini removed the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 21, 2023
@tommasini tommasini mentioned this pull request Aug 21, 2023
Merged
3 tasks
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 23, 2023
cortisiko
cortisiko approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the dev test cases are good. ✅

@tommasini tommasini merged commit 7ad6016 into feat/824-batch Aug 23, 2023
@tommasini tommasini deleted the feat/1162-ipfs branch August 23, 2023 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tommasini @codecov-commenter @sethkfman @cortisiko @gauthierpetetin