Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use Redux network controller state #6848

Merged
merged 1 commit into from
Jul 20, 2023
Merged

refactor: Use Redux network controller state #6848

merged 1 commit into from
Jul 20, 2023
+37 −37

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 20, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Various UI components have been updated to use Redux network controller state (via selectors) rather than directly accessing the controller state using the Engine global.

Issue

Relates to MetaMask/mobile-planning#1016

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 20, 2023
@Gudahtt Gudahtt force-pushed the replace-some-direct-network-state-references branch from 7e8ea70 to a2b9ffd Compare July 20, 2023 04:45
@Gudahtt Gudahtt marked this pull request as ready for review July 20, 2023 04:58
@Gudahtt Gudahtt requested a review from a team as a code owner July 20, 2023 04:58
@Gudahtt Gudahtt force-pushed the replace-some-direct-network-state-references branch from a2b9ffd to 20ae552 Compare July 20, 2023 12:27
@Gudahtt
Copy link
Member Author

Gudahtt commented Jul 20, 2023

Passing e2e test: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/271685b0-673c-497f-af94-1ad74e7acf4d

@Gudahtt Gudahtt mentioned this pull request Jul 20, 2023
Closed
3 tasks
@Gudahtt Gudahtt added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 20, 2023
@Gudahtt
refactor: Use Redux network controller state
dd93a8e 
Various UI components have been updated to use Redux network controller
state (via selectors) rather than directly accessing the controller
state using the `Engine` global.

Relates to MetaMask/mobile-planning#1016
@Gudahtt Gudahtt force-pushed the replace-some-direct-network-state-references branch from 20ae552 to dd93a8e Compare July 20, 2023 20:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Cal-L
Cal-L approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added release-7.5.0 Issue or pull request that will be included in release 7.5.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 20, 2023
@Gudahtt Gudahtt merged commit a8d0613 into main Jul 20, 2023
@Gudahtt Gudahtt deleted the replace-some-direct-network-state-references branch July 20, 2023 21:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.5.0 Issue or pull request that will be included in release 7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @Cal-L