fix: approval request with id x not found #6838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
added
team-confirmations-system
matthewwalsh0
approved these changes
Jul 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
chrisleewilcox
added
the
Spot Check on the Release Build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
To reproduce it, follow these steps: create a token, leave the modal open, and move the MMM app to the background. When you bring the MMM back to the foreground, you will encounter the error.
Additional reports on sentry: https://metamask.sentry.io/issues/?project=2299799&query=is%3Aunresolved+Approval&referrer=issue-list&statsPeriod=30d&utc=true
Screenshots/Recordings
After fix:
create-token-fixed.webm
Before fix:
before-fix.webm
Issue
resolves: #6774
E2E Pipeline
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6778146f-5e13-4f23-b31f-4665bfb01b85
Checklist