Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define ReactNativePayments podspec path in podfile #6821

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: define ReactNativePayments podspec path in podfile #6821

merged 1 commit into from
Jul 17, 2023

Conversation

wachunei
Copy link
Member

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds back react-native-payments to the linked pods by explicitly adding the podspec path to the Podfile, since it is not at the package level and it was not being autolinked.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei requested a review from a team as a code owner July 17, 2023 15:04
@chrisleewilcox chrisleewilcox added release-7.4.0 Issue or pull request that will be included in release 7.4.0 release bug Issues that arise during regression testing that block release and removed release bug Issues that arise during regression testing that block release labels Jul 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug D 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

15.0% 15.0% Coverage
0.0% 0.0% Duplication

sethkfman
sethkfman approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 17, 2023
@wachunei
Copy link
Member Author

I confirm this is linking the package again by getting the Apple Pay UI locally.

@wachunei wachunei added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 17, 2023
@wachunei wachunei merged commit a9aded3 into release/7.4.0 Jul 17, 2023
@wachunei wachunei deleted the fix/payments-podspec branch July 17, 2023 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.4.0 Issue or pull request that will be included in release 7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @sethkfman @chrisleewilcox