Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add security alerts settings to experimental tab #6779

Merged
merged 7 commits into from
Aug 4, 2023
Merged

feat: Add security alerts settings to experimental tab #6779

merged 7 commits into from
Aug 4, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Jul 10, 2023 •
edited
Loading

Description

Explanation

As we introduce the Blockaid security provider feature we should add a toggle under experimental to allow users to turn the feature on and off.

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/527

Screenshots/Screencaps

Screenshot 2023-07-10 at 21 59 48

Manual Testing Steps

  1. Open Settings
  2. Tab Experimental
  3. You should see the screenshot above
  4. Toggle button should be off by default
  5. Tap on the toggle button it should stay on
  6. Restart MetaMask
  7. Toggle should remain on
  8. Repeat steps 5-7, this time make sure toggle stays off

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun force-pushed the olu/blockaid-settings branch from 6fbea63 to 81148b1 Compare July 10, 2023 18:41
@segun segun self-assigned this Jul 10, 2023
@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Jul 11, 2023
@segun segun force-pushed the olu/blockaid-settings branch from 4b4da27 to 30e1ee6 Compare July 12, 2023 14:08
@segun segun requested a review from a team as a code owner July 12, 2023 14:08
@segun segun force-pushed the olu/blockaid-settings branch from 30e1ee6 to a34676e Compare July 18, 2023 08:23
jpuri
jpuri previously approved these changes Jul 19, 2023
View reviewed changes
@segun segun force-pushed the olu/blockaid-settings branch from a34676e to 438b634 Compare July 20, 2023 13:12
jpuri
jpuri previously approved these changes Jul 20, 2023
View reviewed changes
blackdevelopa
blackdevelopa previously approved these changes Jul 20, 2023
View reviewed changes
@segun segun changed the title feat: Add security alerts settings to experimental tab !!!DO_NOT_MERGE: Add security alerts settings to experimental tab Jul 24, 2023
@blackdevelopa blackdevelopa removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 26, 2023
@bschorchit bschorchit added the DO-NOT-MERGE Pull requests that should not be merged label Jul 26, 2023
@segun segun dismissed stale reviews from blackdevelopa and jpuri via f5367fb August 3, 2023 13:47
@segun segun force-pushed the olu/blockaid-settings branch from 438b634 to f5367fb Compare August 3, 2023 13:47
@segun segun changed the title !!!DO_NOT_MERGE: Add security alerts settings to experimental tab feat: Add security alerts settings to experimental tab Aug 3, 2023
@segun segun removed the DO-NOT-MERGE Pull requests that should not be merged label Aug 3, 2023
@blackdevelopa
Copy link
Contributor

@segun can this now be merged?

@segun
Copy link
Contributor Author

segun commented Aug 4, 2023

@segun can this now be merged?

Yes it can. @blackdevelopa

segun added 5 commits August 4, 2023 15:18
@segun
Add security alerts settings to experimental tab
f8bb63f 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
add more providers label
c2a2a8a 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
change styles label
a6cfb0d 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
Fix tests
dccc0fc 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
Sort imports
56bd5c7 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
segun added 2 commits August 4, 2023 15:18
@segun
use environment var to determine if to show blockaid or not
e861fda 
Signed-off-by: Olusegun Akintayo <akintayo.segun@gmail.com>
@segun
Removed Podfile changes
3a126d8
@segun segun force-pushed the olu/blockaid-settings branch from 74820f5 to 3a126d8 Compare August 4, 2023 14:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

84.0% 84.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@segun segun merged commit fb1184c into main Aug 4, 2023
@segun segun deleted the olu/blockaid-settings branch August 4, 2023 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 4, 2023
@segun segun restored the olu/blockaid-settings branch October 3, 2023 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

@jpuri jpuri jpuri approved these changes

Assignees

@segun segun

Labels
release-7.6.0 Issue or pull request that will be included in release 7.6.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@segun @blackdevelopa @jpuri @bschorchit @metamaskbot