fix: sending an ERC20 token with an amount with more decimals than the token decimal, results in nothing #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
blackdevelopa
changed the title
blackdevelopa
added
needs-dev-review
jpuri
previously approved these changes
Jul 7, 2023
cryptotavares
previously approved these changes
Jul 10, 2023
blackdevelopa
added
needs-qa
digiwand
approved these changes
Jul 10, 2023
|
@blackdevelopa I can see how the issue is fixed now 🔥 PR can be merged send-token-decimals-erc20.mp4There is a related issue affecting deeplinks, in case you want to grab this in the future as it's related work. It's #6323 |
seaona
added
QA Passed
digiwand
previously approved these changes
Jul 11, 2023
seaona
added
the
release-7.4.0
blackdevelopa
dismissed stale reviews from digiwand, cryptotavares, and jpuri
via
606f8d1
blackdevelopa
force-pushed
the
6324/sending-erc20-with-higher-token-decimal-error
branch
from
e18b272 to
606f8d1
Compare
digiwand
approved these changes
Jul 11, 2023
cryptotavares
approved these changes
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed! |
blackdevelopa
deleted the
6324/sending-erc20-with-higher-token-decimal-error
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Whenever we are trying to Send an ERC20 token, if we input an amount with more decimals than the contract is expecting, whenever we click Next, nothing happens. The improved solution is to mirror the extension by rounding off the number if it the fraction length is more than the token decimal
Screenshots/Recordings
Before:
235894032-42019be5-f7a0-421a-b450-504a23af58e7.mp4
After:
Screen.Recording.2023-07-07.at.04.43.56.mov
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #6324
Checklist