-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(551): add Linea Mainnet #6496
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
2c41a8c
to
97b6b03
Compare
@VGau are these ready for dev-review? |
7350705
to
e4d2119
Compare
@sethkfman Yes it is ready for dev review :) |
e4d2119
to
1ce6576
Compare
Do you know when the functional url is going to be in place so you can show a successful transaction? |
I don't have the answer yet sorry. For now there is a feature toggle for linea mainnet so that it won't be displayed :) |
b0978ef
to
88f2296
Compare
@VGau Can you add a video showing this there is no functional impact to displaying the current networks? Also, can you add a description how you plan to test the network and if it fails how it will be disabled? This will help QA understand the feature is triggered from a specific response on infura endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cortisiko This is a dormant feature that is enabled via infura flag. You will not see any functional difference. It should only need regression/e2e QA but I wanted you to confirm. |
hey @VGau a couple of things:
|
Hey @cortisiko :
|
fdaa172
to
fe77740
Compare
The feature toggle for the linea mainnet network performs two checks:
If one of those two checks is false, the linea mainnet won't be displayed. |
By default the linea mainnet network won't be displayed on MM. It will be displayed only if the current date time is higher than July 11th and if the linea mainnet rpc url is working. |
@VGau Can you resolve the conflicts? It looks like the testnet PR is causing issues. We will get the PR merge on Tuesday. |
e7b5cdc
to
d721f0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
Note:⚠️ For now, the linea mainnet url is not working so I cannot record a successful transaction for the new linea mainnet network.
Screenshots/Recordings
zEsRhpdUna.mp4
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #???
Checklist