Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(browser): added remaining fields in WebSourceResponse patch #6479

Merged
merged 9 commits into from
Jul 25, 2023
Merged

fix(browser): added remaining fields in WebSourceResponse patch #6479

merged 9 commits into from
Jul 25, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented May 26, 2023 •
edited
Loading

Description

This PR adds properties to WebSourceResponse including headers of response.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman marked this pull request as ready for review July 19, 2023 19:53
@sethkfman sethkfman requested a review from a team as a code owner July 19, 2023 19:53
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Jul 19, 2023
@sethkfman
Copy link
Contributor Author

E2E Test: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07bbcea1-458d-45cf-b26c-09665e410c16

@sethkfman
Copy link
Contributor Author

E2E Tests: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f4fd091-26a2-4f74-9d74-b902dcb5172c

@sethkfman sethkfman requested a review from NicholasEllul July 20, 2023 15:49
@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 20, 2023
Cal-L
Cal-L previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 21, 2023
NicholasEllul
NicholasEllul previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@NicholasEllul NicholasEllul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sethkfman sethkfman dismissed stale reviews from NicholasEllul and Cal-L via 895534e July 25, 2023 17:05
@sethkfman sethkfman added the release-7.5.0 Issue or pull request that will be included in release 7.5.0 label Jul 25, 2023
@sethkfman
Copy link
Contributor Author

E2E Rerun: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5cd1c4a-0f32-41e8-af52-d1e93baeef7a

Cal-L
Cal-L approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman merged commit 35992d2 into main Jul 25, 2023
@sethkfman sethkfman deleted the fix/browser-headers branch July 25, 2023 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
@NicholasEllul NicholasEllul restored the fix/browser-headers branch August 24, 2023 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@NicholasEllul NicholasEllul NicholasEllul left review comments

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.5.0 Issue or pull request that will be included in release 7.5.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethkfman @Cal-L @NicholasEllul @gauthierpetetin