Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DETOX] Only Run tests with the "smoke" tag in the describe block #6338

Merged
merged 7 commits into from
May 4, 2023

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented May 4, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

The purpose of this PR is to ensure that, by default on Bitrise, only the e2e tests containing the "smoke" tag in the describe block will be executed.

To accomplish this, the Jest flag --testNamePattern was used. To give this a try locally run this command:
yarn test:e2e:ios:debug --testNamePattern=Smoke

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cortisiko cortisiko requested a review from a team as a code owner May 4, 2023 15:30
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit 373e478 into main May 4, 2023
@cortisiko cortisiko deleted the detox/smoke-tests branch May 4, 2023 23:23
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants