Collectible transaction details #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MetaMask into collectible-tx-details
brunobar79
approved these changes
Feb 16, 2019
| {this.renderTxTime()} | ||
| <View style={styles.subRow}> | ||
| {contractDeployment ? ( | ||
| <Image source={ethLogo} style={styles.ethLogo} /> |
There was a problem hiding this comment.
Wrap it with FadeIn from 'react-native-fade-in-image'
… into collectible-tx-details
Merged
brunobar79
pushed a commit
that referenced
this pull request
Feb 18, 2019
* URL Autocomplete (#378) * initial work for autocomplete * initial work for autocomplete * autocomplete working * Fix typo * More missing locales (#381) * add missing locales * snapshot * Support for develop branch (#377) * Fade in images + bugfixes (#385) * initial work for autocomplete * initial work for autocomplete * autocomplete working * fade in images everywhere * fade in images + fixes * fix snapshots * fix qr codes (#386) * Collectible transaction details (#390) * decode transfer data ERC721 * render tx element * tx details refactor * stable * more refactor * renderable gasprice * render hash * snapshots * fadein * Remove collectible if is being sent (#391) * delete collectible if collectible is being sent * remove collectible before clear tx * if * iOS Unsafe devices + other bugfixes (#389) * add remember me for unprotected devices * increase keychain security level * fix snapshots * fixes * dont pop submit view when going to etherscan * handle android back button * Upgrade react native to v0.58.4 (#393) * ios app working * rn navigation & co updated * fix snapshots * remove extra files * add mm faucet * fix detox android * Import from seed - "remember me" option (#394) * Added missing remember me in import from seed flow * Update snapshot * refactor complete (#395) * Portrait orientation by default (#397) * fix navbar when landscape * fix portrait * portrait android * revert * indentation * Lock deps by commit sha1 (#400) * lock deps by commit sha * fix merge conflicts * Show app version (#399) * refactor complete * show app version in settings => info * fix bad indentation * bump gaba (#401)
brunobar79
pushed a commit
that referenced
this pull request
Feb 19, 2019
* Release 0.1.4 (#402) * URL Autocomplete (#378) * initial work for autocomplete * initial work for autocomplete * autocomplete working * Fix typo * More missing locales (#381) * add missing locales * snapshot * Support for develop branch (#377) * Fade in images + bugfixes (#385) * initial work for autocomplete * initial work for autocomplete * autocomplete working * fade in images everywhere * fade in images + fixes * fix snapshots * fix qr codes (#386) * Collectible transaction details (#390) * decode transfer data ERC721 * render tx element * tx details refactor * stable * more refactor * renderable gasprice * render hash * snapshots * fadein * Remove collectible if is being sent (#391) * delete collectible if collectible is being sent * remove collectible before clear tx * if * iOS Unsafe devices + other bugfixes (#389) * add remember me for unprotected devices * increase keychain security level * fix snapshots * fixes * dont pop submit view when going to etherscan * handle android back button * Upgrade react native to v0.58.4 (#393) * ios app working * rn navigation & co updated * fix snapshots * remove extra files * add mm faucet * fix detox android * Import from seed - "remember me" option (#394) * Added missing remember me in import from seed flow * Update snapshot * refactor complete (#395) * Portrait orientation by default (#397) * fix navbar when landscape * fix portrait * portrait android * revert * indentation * Lock deps by commit sha1 (#400) * lock deps by commit sha * fix merge conflicts * Show app version (#399) * refactor complete * show app version in settings => info * fix bad indentation * bump gaba (#401) * Update README.md (#327) * Update README.md * Updated instructions * Update README.md * fix indentation * remove tabs * Revert "Update README.md (#327)" (#406) This reverts commit 403e63c. * Revert "Revert "Update README.md (#327)" (#406)" This reverts commit ebd8a4f.
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* decode transfer data ERC721 * render tx element * tx details refactor * stable * more refactor * renderable gasprice * render hash * snapshots * fadein
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Release 0.1.4 (#402) * URL Autocomplete (#378) * initial work for autocomplete * initial work for autocomplete * autocomplete working * Fix typo * More missing locales (#381) * add missing locales * snapshot * Support for develop branch (#377) * Fade in images + bugfixes (#385) * initial work for autocomplete * initial work for autocomplete * autocomplete working * fade in images everywhere * fade in images + fixes * fix snapshots * fix qr codes (#386) * Collectible transaction details (#390) * decode transfer data ERC721 * render tx element * tx details refactor * stable * more refactor * renderable gasprice * render hash * snapshots * fadein * Remove collectible if is being sent (#391) * delete collectible if collectible is being sent * remove collectible before clear tx * if * iOS Unsafe devices + other bugfixes (#389) * add remember me for unprotected devices * increase keychain security level * fix snapshots * fixes * dont pop submit view when going to etherscan * handle android back button * Upgrade react native to v0.58.4 (#393) * ios app working * rn navigation & co updated * fix snapshots * remove extra files * add mm faucet * fix detox android * Import from seed - "remember me" option (#394) * Added missing remember me in import from seed flow * Update snapshot * refactor complete (#395) * Portrait orientation by default (#397) * fix navbar when landscape * fix portrait * portrait android * revert * indentation * Lock deps by commit sha1 (#400) * lock deps by commit sha * fix merge conflicts * Show app version (#399) * refactor complete * show app version in settings => info * fix bad indentation * bump gaba (#401) * Update README.md (#327) * Update README.md * Updated instructions * Update README.md * fix indentation * remove tabs * Revert "Update README.md (#327)" (#406) This reverts commit 403e63c. * Revert "Revert "Update README.md (#327)" (#406)" This reverts commit ebd8a4f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have collectibles support we can display respective data on transactions detail.
The GIF starts without the collectible information in state, that's why the transaction is shown without specific collectible information at the beginning.
It also adds code refactor to maintain logic in
TransactionElementleaving toTransactionDetailsthe responsibility to render information.Checklist
Issue
Resolves #366