-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental account security #360
Conversation
0701d6c
to
c6f0b02
Compare
This is probably going to take me a while to fully QA it so I'll add comments as I find something new (if I do) While importing account. When user imports account password is set but if the account has balance the view containing |
When Exploring and Log out. If I choose |
Protect your funds touchable ( backUp alert ) I didn't find this in Figma, wouldn't we want it in the wallet section as well? |
RE 1st comment: Good catch! forgot to set the flags on those scenarios. Just fixed it. RE 2nd comment: I'm planning to remove log out for users who didn't set a password before private beta. I'm leaving it for now because it's the only way to try the flow. RE 3rd comment: It is here: https://www.figma.com/file/BDcfanN7wCZqbB446t8szhQy/MetaMask-Mobile?node-id=36%3A304 (last column) In the wallet it might interfere with tokens / collectibles, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments addressed, QAed both Android and IOS. Have no comments about the code itself. This PR is awesome!!
* incoming asset detection * added create your account screen * added choose password screen with anim. placeholders * done with choose password screen * fix scrollview * save your seed screen * added skip button * add first 4 steps * finish all steps * minor style fixes * move strings to locale files * rest of strings to locales * update snapshots * scrollviews and testIDs * update snapshots * clean up and redux * lint fix * remove .orig * update onboarding screen * update old flow * lint * update unit tests * flow fully working * seed phrase backup flow working fine * fix unit tests * fix learn more * fix buttons * fix android styles * update snapshots * add latest JSC * use animated fox in browser home * fix words order bug * clean up * bump react-native * update snapshots * fix code review comments * update snapshots
Description
Implemented all the functionality from #185 which can be seen here: https://www.figma.com/proto/BDcfanN7wCZqbB446t8szhQy/MetaMask-Mobile?node-id=427%3A0&viewport=-153%2C570%2C0.760407&scaling=scale-down&redirected=1
Checklist
Extras
Issue
Resolves #185