Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental account security #360

Merged
merged 38 commits into from
Feb 12, 2019
Merged

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Feb 5, 2019

Description

Implemented all the functionality from #185 which can be seen here: https://www.figma.com/proto/BDcfanN7wCZqbB446t8szhQy/MetaMask-Mobile?node-id=427%3A0&viewport=-153%2C570%2C0.760407&scaling=scale-down&redirected=1

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Extras

Issue

Resolves #185

@brunobar79 brunobar79 changed the title [WIP] - Incremental account security Incremental account security Feb 8, 2019
@brunobar79 brunobar79 force-pushed the incremental-account-security branch 2 times, most recently from 0701d6c to c6f0b02 Compare February 8, 2019 22:19
@estebanmino
Copy link
Contributor

This is probably going to take me a while to fully QA it so I'll add comments as I find something new (if I do)

While importing account. When user imports account password is set but if the account has balance the view containing ETH was deposited in your account flow still appears with the first transaction. Moreover this transaction is in Ropsten so I guess it shouldn't start the back up flow. Then if I follow the flow and set a password I get a Invalid password error, I'm guessing is because i already have a password.

@estebanmino
Copy link
Contributor

When Exploring and Log out. If I choose Start exploring now and then I log out, when I go again to Start exploring now I get a different account . I'm thinking in an user that gives the address to a friend to deposit ETH, if the app is logged out or the phone turned off, the user may lost that account and deposit.

@estebanmino
Copy link
Contributor

Protect your funds touchable ( backUp alert ) I didn't find this in Figma, wouldn't we want it in the wallet section as well?

@brunobar79
Copy link
Contributor Author

RE 1st comment: Good catch! forgot to set the flags on those scenarios. Just fixed it.
Also FYI, I'm running the flow in testnets too, otherwise we would have to pay for testing it.

RE 2nd comment: I'm planning to remove log out for users who didn't set a password before private beta. I'm leaving it for now because it's the only way to try the flow.

RE 3rd comment: It is here: https://www.figma.com/file/BDcfanN7wCZqbB446t8szhQy/MetaMask-Mobile?node-id=36%3A304 (last column)
Personally I think it's enough to be displayed there since the browser is the home screen so users will see it every time they launch the app.

In the wallet it might interfere with tokens / collectibles, etc.

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed, QAed both Android and IOS. Have no comments about the code itself. This PR is awesome!!

@brunobar79 brunobar79 merged commit 4ba792b into master Feb 12, 2019
@brunobar79 brunobar79 deleted the incremental-account-security branch February 18, 2019 18:51
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* incoming asset detection

* added create your account screen

* added choose password screen with anim. placeholders

* done with choose password screen

* fix scrollview

* save your seed screen

* added skip button

* add first 4 steps

* finish all steps

* minor style fixes

* move strings to locale files

* rest of strings to locales

* update snapshots

* scrollviews and testIDs

* update snapshots

* clean up and redux

* lint fix

* remove .orig

* update onboarding screen

* update old flow

* lint

* update unit tests

* flow fully working

* seed phrase backup flow working fine

* fix unit tests

* fix learn more

* fix buttons

* fix android styles

* update snapshots

* add latest JSC

* use animated fox in browser home

* fix words order bug

* clean up

* bump react-native

* update snapshots

* fix code review comments

* update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants