Block add custom collectible when user is not the owner #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
brunobar79
approved these changes
Feb 4, 2019
locales/en.json
Outdated
| @@ -127,7 +127,9 @@ | |||
| "collectible_token_id": "ID", | |||
| "address_must_be_valid": "Collectible address must be a valid address.", | |||
| "address_cant_be_empty": "Collectible address can't be empty.", | |||
| "token_id_cant_be_empty": "Collectible identifier can't be empty." | |||
| "token_id_cant_be_empty": "Collectible identifier can't be empty.", | |||
| "ownership_error_title": "Invalid addition", | |||
There was a problem hiding this comment.
I'd put some generic thing like, "Ooops, something happened." the word addition sounds like a math operation.
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* block add custom collectible when user not owner * test * handle contract errors * change locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR blocks users of adding collectibles that they don't own.
Needs better error message formatting.
Checklist
Issue
Resolves #354