Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/chain ticker #2442

Merged
merged 18 commits into from
Apr 5, 2021
Merged

Improvement/chain ticker #2442

merged 18 commits into from
Apr 5, 2021

Conversation

estebanmino
Copy link
Contributor

Description

I could only find these places:

  • Accounts list
  • Message of not enough ETH
  • Payment requests on custom RPC networks. it's also now generating the correct deeplinks for other chainId
  • Receive flows

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2388

@estebanmino estebanmino requested a review from a team as a code owner March 29, 2021 15:48
@estebanmino estebanmino added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. next release labels Mar 29, 2021
ibrahimtaveras00
ibrahimtaveras00 suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question

I noticed in #2388 (comment) it mentions the logo/symbol as well, is that no longer a requirement?
cc: @omnat

image

Screen Shot 2021-03-29 at 8 24 34 PM

Issue 1:

When I do the receive flow and scan the deeplink while on xDAI and requesting xDAI I get this with a spinner/white screen

Screen Shot 2021-03-29 at 8 26 18 PM

I used this QR:
Screen Shot 2021-03-29 at 8 24 55 PM

Issue 2:

I found another place where we still show ETH in the send flow

image

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 30, 2021
@omnat
Copy link
Contributor

omnat commented Mar 30, 2021

cc @wachunei @jakehaugen

@estebanmino
Copy link
Contributor Author

@ibrahimtaveras00 all issues resolved and now we're displaying a gray icon with the first letter of the ticker for custom networks if the symbol of such is network isn't ETH (as rinkeby, and other testnets)

@estebanmino estebanmino added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Apr 1, 2021
@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 5, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixes look good, QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Apr 5, 2021
@estebanmino estebanmino merged commit 63e8cf4 into develop Apr 5, 2021
@estebanmino estebanmino deleted the improvement/chain-ticker branch April 5, 2021 23:16
rickycodes added a commit that referenced this pull request Apr 8, 2021
@rickycodes
Merge branch 'develop' into feature/confusables
6f99419 
* develop:
  v2.1.0 (#2481)
  Analytics v2 (priority 1) (#2456)
  Fix/gas estimations (#2408)
  remove controllers tgz (#2479)
  Improvement/assets by chainid (#2441)
  Improvement/chain ticker (#2442)
  Remove instapay (#2372)
  Fix iOS build (#2467)
  Migrate from AsyncStorage to FileStorage (#2084)
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
Improvement/chain ticker (#2442)
b8028ac 
* accounts

* not_enough_for_gas

* locales

* fixpaymentrequest

* receiveflow

* receiveonpress

* ticker

* NetworkMainAssetLogo

* moreticker

* handleNetworkSwitch

* snaps

* fix

* compare

* setRpcTarget

* nickname

* shortName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

@rickycodes rickycodes rickycodes approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instead of ETH - show me native currency (+symbol)
4 participants
@estebanmino @omnat @rickycodes @ibrahimtaveras00