-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cp-7.42.0 Move AssetsPollingProvider down a level to persist tab label #13962
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a test perspective ✅
|
Description
ScrollableTabView
requires it's immediate children to have atabLabel
in order to render the text correctly.AssetsPollingProvider
has no label. Moving the provider down a level resolved the bug.Related issues
Fixes: #13930
Manual testing steps
Screenshots/Recordings
Before
Screenshot in bug report
After
Pre-merge author checklist
Pre-merge reviewer checklist