Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-7.42.0 Move AssetsPollingProvider down a level to persist tab label #13962

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Mar 11, 2025

Description

ScrollableTabView requires it's immediate children to have a tabLabel in order to render the text correctly. AssetsPollingProvider has no label. Moving the provider down a level resolved the bug.

Related issues

Fixes: #13930

Manual testing steps

  1. Go to main wallet screen
  2. Tokens tab should render
  3. Token list with balances should render and be functional

Screenshots/Recordings

Before

Screenshot in bug report

After

Screenshot 2025-03-11 at 10 57 37 AM Screenshot 2025-03-11 at 1 27 42 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title fix: Move AssetPolling provider down a level to enable tab text rende… fix: Move AssetsPollingProvider down a level to persist tab label Mar 11, 2025
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d294239
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4d4641b3-f06d-4798-ad34-aa2a8e44eb9e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish changed the title fix: Move AssetsPollingProvider down a level to persist tab label fix: cp-7.42.0 Move AssetsPollingProvider down a level to persist tab label Mar 11, 2025
@gambinish gambinish marked this pull request as ready for review March 11, 2025 20:22
@gambinish gambinish requested review from a team as code owners March 11, 2025 20:22
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a test perspective ✅

@MarioAslau MarioAslau added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 447697b Mar 11, 2025
39 checks passed
@MarioAslau MarioAslau deleted the fix/13930-token-tab-label-rendering branch March 11, 2025 23:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: In place of the expected Tokens tab name, there is an empty space.
5 participants