Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds necessary initial code to work with non-evm transactions #13954

Merged
merged 9 commits into from
Mar 12, 2025
Merged

chore: adds necessary initial code to work with non-evm transactions #13954

merged 9 commits into from
Mar 12, 2025

Conversation

zone-live
Copy link
Contributor

Description

This PR adds the initial bootstrap code that will allow us to work with the non-evm transactions in mobile.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested review from a team as code owners March 11, 2025 14:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live changed the title chore: adds necessary bootstrap code to work with non-evm transactions chore: adds necessary initial code to work with non-evm transactions Mar 11, 2025
@zone-live
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@socket-security Socket Security
Copy link

socket-security bot commented Mar 11, 2025 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/multichain-transactions-controller@0.7.0 Transitive: network +5 2.49 MB metamaskbot
npm/@metamask/phishing-controller@12.3.2 ➜ 12.4.0 None 0 348 kB danfinlay, gudahtt, kumavis, ...6 more
npm/@metamask/snaps-controllers@10.0.0 ➜ 9.19.1 None 0 1.81 MB metamaskbot
npm/@metamask/snaps-rpc-methods@11.12.0 ➜ 11.13.1 None 0 0 B
npm/@metamask/snaps-sdk@6.18.0 ➜ 6.19.0 None 0 1.53 MB danfinlay, gudahtt, kumavis, ...6 more

View full report↗︎

aganglada
aganglada reviewed Mar 11, 2025
View reviewed changes
@zone-live zone-live added No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. labels Mar 11, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zone-live zone-live requested a review from aganglada March 11, 2025 16:23
tommasini
tommasini approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goood!!!! <3

@zone-live zone-live added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit bca8e65 Mar 12, 2025
39 checks passed
@zone-live zone-live deleted the SOL-193-non-evm-transactions branch March 12, 2025 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aganglada aganglada aganglada approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.43.0 Issue or pull request that will be included in release 7.43.0 team-sol
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zone-live @aganglada @tommasini @metamaskbot