Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump @metamask/notification-services-controller to 2.0.0 #13857

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

Description

Bumps @metamask/notification-services-controller@2.0.0.

Related issues

Fixes: #13838

Manual testing steps

This is a build release, no changes are introduces to the notification flow.

Test Notifications Feature:

  1. Enable/Disable Notifications
    1. Onboard Wallet
    2. Click Bell Icon and enable notifications
    3. Visit Notification Settings and disable notifications
  2. Enable/Disable Account Notification Settings
    1. Visit Notification Settings and enable/disable notifications for an account

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners March 5, 2025 10:19
Copy link
Contributor

github-actions bot commented Mar 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/notification-services-controller@1.0.02.0.0 None 0 1.37 MB metamaskbot

View full report↗︎

Copy link

sonarqubecloud bot commented Mar 5, 2025

@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 5, 2025
Copy link
Contributor

github-actions bot commented Mar 5, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0dddb04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/98cad572-96a9-4dcc-99b1-ab95a302eb98

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 2f83248 Mar 5, 2025
45 of 48 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the bump/notification-services-controller-2.0.0 branch March 5, 2025 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update metamask/notification-services-controller to version 2.0.0
4 participants