Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing POL percentage trend #13812

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

gambinish
Copy link
Contributor

Description

1 day percent change was not displaying on POL token list item. This is because we were relying on the zeroAddress utility from ethers.js. This is not always correct, because POL is a native token without a zero address.

This PR leverages the getNativeTokenAddress utility from assets controllers to handle this override. Percent change should now be visible.

Related issues

Fixes: #12730

Manual testing steps

Screenshots/Recordings

Screenshot 2025-03-03 at 2 49 43 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish requested a review from a team as a code owner March 3, 2025 22:51
Copy link
Contributor

github-actions bot commented Mar 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title fix: Add getNativeAddress helper function for native tokens without z… fix: Missing POL percentage trend Mar 3, 2025
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 001b5c2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b13ba93b-f234-47bb-b329-2c2b22a8c710

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ac41cca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bafba62a-4d32-46ea-b657-3641b2111588

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Mar 5, 2025

@gambinish gambinish added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit f37497a Mar 5, 2025
39 checks passed
@gambinish gambinish deleted the fix/POL-price-percentage-change-list-item branch March 5, 2025 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@metamaskbot metamaskbot added the release-7.43.0 Issue or pull request that will be included in release 7.43.0 label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.43.0 Issue or pull request that will be included in release 7.43.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: For the POL token, market data is not visible in the general overview
3 participants