-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate blockaid alert into the Alert System #13744
Open
vinistevam
wants to merge
85
commits into
main
Choose a base branch
from
feat/add-blockaid-alert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+843
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tamask-mobile into feat/add-alert-modal
474d047
to
3199708
Compare
digiwand
reviewed
Mar 8, 2025
app/components/Views/confirmations/hooks/alerts/useBlockaidAlerts.test.tsx
Outdated
Show resolved
Hide resolved
digiwand
previously approved these changes
Mar 8, 2025
Nice! can re-review/approve after merge conflicts are resolved |
|
digiwand
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to integrate the blockaid alert into the Alert System only for Signatures.
This alert fires once the Security Alert API reply the request validation with
result_type
property withmalicious
orwarning
.Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2148
Manual testing steps
PPOM - Malicious Transactions and Signatures
click on all SignaturesTransaction scenario
Transactions are using the old banner alert so it should work as before.
Screenshots/Recordings
blockaid.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist