Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate blockaid alert into the Alert System #13744

Open
wants to merge 85 commits into
base: main
Choose a base branch
from

Conversation

vinistevam
Copy link
Contributor

@vinistevam vinistevam commented Feb 27, 2025

Description

This PR aims to integrate the blockaid alert into the Alert System only for Signatures.
This alert fires once the Security Alert API reply the request validation with result_type property with malicious or warning .

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2148

Manual testing steps

  1. Go to Test dapp
  2. In the section PPOM - Malicious Transactions and Signatures click on all Signatures
  3. A banner should appear once you try to confirm the confirm modal so the users can acknowledge the risk and confirm or reject.

Transaction scenario
Transactions are using the old banner alert so it should work as before.

Screenshots/Recordings

blockaid.mp4

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam requested review from a team as code owners March 5, 2025 09:11
@vinistevam vinistevam force-pushed the feat/add-blockaid-alert branch from 474d047 to 3199708 Compare March 5, 2025 09:25
@vinistevam vinistevam removed request for a team March 5, 2025 09:30
@MetaMask MetaMask deleted a comment from codecov-commenter Mar 5, 2025
Base automatically changed from feat/add-inline-alert to main March 5, 2025 14:59
digiwand
digiwand previously approved these changes Mar 8, 2025
@digiwand
Copy link
Contributor

digiwand commented Mar 8, 2025

Nice! can re-review/approve after merge conflicts are resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants