Detox: Update for new send flow #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
changed the title
ibrahimtaveras00
changed the title
ibrahimtaveras00
requested review from
estebanmino
and removed request for
brunobar79
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* make some fixes to accomodate new send flow * make send flow great again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the file e2e/wallet-tests.spec.js to accommodate the new send flow which was pushed earlier this week.
I added and updated the following tests:
tests against both an invalid and valid 0x address (since this is Rinkeby it doesn't do ENS, I'll open a separate PR for address book/contacts tests that does this on mainnet)
tests against a value greater than asset balance, a valid value within the asset balance, and validates amount total
validates ETH total in fiat amount and sends txn
Seen here = https://recordit.co/CTHqCoWo2E
Passing on both OS's