Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change browser homepage for e2e #12839

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

cortisiko
Copy link
Member

Description

In an effort to mitigate flakiness introduced by #12019, the purpose of this PR is to change the default browser home page from the portfolio dapp to the test dapp.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
@cortisiko cortisiko self-assigned this Jan 6, 2025
@cortisiko cortisiko requested a review from a team as a code owner January 6, 2025 19:58
Copy link
Contributor

github-actions bot commented Jan 6, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1af5ffa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a0487c60-a729-4713-8676-0cf0a39343b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Jan 6, 2025

@cortisiko cortisiko enabled auto-merge January 6, 2025 20:39
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 5c222ad Jan 6, 2025
48 checks passed
@cortisiko cortisiko deleted the detox/test-dapp-as-default branch January 6, 2025 21:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@metamaskbot metamaskbot added the release-7.40.0 Issue or pull request that will be included in release 7.40.0 label Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.40.0 Issue or pull request that will be included in release 7.40.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants