Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: send failing contract #12802

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

C-Ivan
Copy link
Contributor

@C-Ivan C-Ivan commented Dec 19, 2024

Description

This PR is within the scope of the Quality Quest.

We're including an e2e test case that send a failing contract in the test dApp.

Steps:
Given I am on the test dapp
When I tap on the Send failing transaction button in the Failing Contract section
Then the transaction bottom sheet should appear
And I should see a warning "this transaction will likely fail" <- This message is not present
When I submit the transaction
Then the transaction should appear in the transaction history

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@C-Ivan C-Ivan self-assigned this Dec 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@C-Ivan C-Ivan added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 19, 2024
@metamaskbot metamaskbot added the team-qa QA team label Dec 19, 2024
@C-Ivan C-Ivan added team-confirmations Push issues to confirmations team team-qa QA team Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-qa QA team labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 00d1af9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6f74a0f0-5afc-42c7-9b7f-f56428784872

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@C-Ivan C-Ivan marked this pull request as ready for review December 19, 2024 22:01
@C-Ivan C-Ivan requested a review from a team as a code owner December 19, 2024 22:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.07%. Comparing base (9d6908b) to head (0ef8188).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12802      +/-   ##
==========================================
+ Coverage   58.85%   59.07%   +0.21%     
==========================================
  Files        1851     1852       +1     
  Lines       41739    41805      +66     
  Branches     5397     5415      +18     
==========================================
+ Hits        24566    24695     +129     
+ Misses      15502    15438      -64     
- Partials     1671     1672       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cortisiko
cortisiko previously approved these changes Dec 19, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@C-Ivan C-Ivan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0ef8188
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b0e9ce67-be47-4fcb-8a10-234d37071ec3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 self-requested a review December 20, 2024 15:03
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@C-Ivan C-Ivan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d4b0d98
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4be286c4-28b3-46bc-9885-c728180f1467

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 920302f Dec 20, 2024
40 checks passed
@cortisiko cortisiko deleted the detox/send-failing-contract-transaction branch December 20, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants