-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: send failing contract #12802
test: send failing contract #12802
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 00d1af9 Note
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12802 +/- ##
==========================================
+ Coverage 58.85% 59.07% +0.21%
==========================================
Files 1851 1852 +1
Lines 41739 41805 +66
Branches 5397 5415 +18
==========================================
+ Hits 24566 24695 +129
+ Misses 15502 15438 -64
- Partials 1671 1672 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ✅ ✅
Bitrise✅✅✅ Commit hash: 0ef8188 Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Bitrise✅✅✅ Commit hash: d4b0d98 Note
|
Description
This PR is within the scope of the Quality Quest.
We're including an e2e test case that send a failing contract in the test dApp.
Steps:
Given I am on the test dapp
When I tap on the Send failing transaction button in the Failing Contract section
Then the transaction bottom sheet should appear
And I should see a warning "this transaction will likely fail" <- This message is not present
When I submit the transaction
Then the transaction should appear in the transaction history
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist