Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated display format for asset currency dif #12775

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix: Updated display format for asset currency dif #12775

merged 3 commits into from
Dec 20, 2024
+9 −3

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Dec 18, 2024 •
edited
Loading

Description

  • This PR updates the format of the change in currency for negative cases to be -$123.45 instead of $-123.45

Related issues

Fixes: #10922

Manual testing steps

  1. Go to Assets
  2. Look at the amount changed in dollars

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 15 Pro Max - 2024-12-18 at 11 57 50
Screenshot_1734563249

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system in Mobile label Dec 18, 2024
@brianacnguyen brianacnguyen self-assigned this Dec 18, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner December 18, 2024 23:10
@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1f2e7c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eed4afda-f1ad-4eb4-adc8-990779a49c42

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen changed the title Updated display format for asset currency dif fix: Updated display format for asset currency dif Dec 18, 2024
georgewrmarshall
georgewrmarshall reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update! Failing snapshot tests

gambinish
gambinish previously approved these changes Dec 18, 2024
View reviewed changes
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a806fc2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3902170-21d3-4e9b-b268-6940d00139a3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@brianacnguyen brianacnguyen added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit ec8804c Dec 20, 2024
40 checks passed
@brianacnguyen brianacnguyen deleted the fix/asset-amount-dif branch December 20, 2024 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 20, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall left review comments

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@gambinish gambinish gambinish approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update price change formatting from $-9.99 to -$9.99 in Portfolio View and Token Details
6 participants
@brianacnguyen @georgewrmarshall @cortisiko @gambinish @NidhiKJha @metamaskbot