Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: approve erc721 token e2e #12767

Merged
merged 2 commits into from
Dec 19, 2024
Merged

test: approve erc721 token e2e #12767

merged 2 commits into from
Dec 19, 2024

Conversation

C-Ivan
Copy link
Contributor

@C-Ivan C-Ivan commented Dec 18, 2024

Description

This PR is within the scope of the Quality Quest.

We're including an e2e test case to approve an ERC721 token.

Test Steps:
Given I am on the test dApp
When I tap on the Approve From button under the ERC 721 section
Then the transaction bottom sheet should appear
When I submit the transaction
Then the transaction should appear in the transaction history

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Dec 18, 2024
@C-Ivan C-Ivan added team-confirmations Push issues to confirmations team No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 69818fc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc284066-0270-4813-8057-47e428a8766e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@C-Ivan C-Ivan self-assigned this Dec 18, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff ! 🌮 🦖

@C-Ivan C-Ivan marked this pull request as ready for review December 18, 2024 21:51
@C-Ivan C-Ivan requested a review from a team as a code owner December 18, 2024 21:51
@C-Ivan C-Ivan added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 3188e22 Dec 19, 2024
36 checks passed
@C-Ivan C-Ivan deleted the detox/approve-an-ERC721 branch December 19, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team team-qa QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants