Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MMPD-1518 - Introduce new browsing experience feature flag #12738

Closed
wants to merge 1 commit into from

Conversation

ziad-saab
Copy link
Contributor

@ziad-saab ziad-saab commented Dec 17, 2024

Description

Introduces the base code to start developing the changes to the browser shown in this Figma >> https://www.figma.com/design/3TneFPnMo203zPPkVqthJZ/Mobile-Explore-%2F-Browser?node-id=46-318&p=f&t=FBEMjJMtPYZZbHzV-0

Changes:

  • Introduce MM_NEW_BROWSING_EXPERIENCE_ENABLED env var
  • Create placeholder screen for new browsing experience
  • Show placeholder screen instead of current browser when flag is on

NewBrowsingExperience* components and variables will probably be renamed once the feature is rolled out.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMPD-1517

Manual testing steps

  1. Set MM_NEW_BROWSING_EXPERIENCE_ENABLED to "true" in your .js.env
  2. Build the app
  3. Navigate to the browser view
  4. Expect a placeholder view called NewBrowsingExperienceView with text "New Browsing Experience Placeholder"

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ziad-saab ziad-saab requested review from a team as code owners December 17, 2024 20:05
@ziad-saab ziad-saab marked this pull request as draft December 17, 2024 20:05
Copy link
Contributor

github-actions bot commented Dec 17, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ziad-saab
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@ziad-saab ziad-saab added No QA Needed Apply this label when your PR does not need any QA effort. team-portfolio labels Jan 6, 2025
@ziad-saab ziad-saab changed the title MMPD-1518: Introduce new browsing experience feature flag feat: MMPD-1518 - Introduce new browsing experience feature flag Jan 6, 2025
@ziad-saab ziad-saab added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 444d316
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2541a588-3110-4530-bb35-c8a8305b31eb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ziad-saab ziad-saab added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
40.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

@ziad-saab ziad-saab force-pushed the zs/new-browsing-experience branch from 3f6aef1 to 33191a6 Compare January 7, 2025 19:52
@ziad-saab ziad-saab closed this Jan 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. team-portfolio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant