Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump nanoid package to 3.3.8 #12725

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

tommasini
Copy link
Contributor

Description

Resolution created to bump nanoid to version 3.3.8!

It can be removed once this controllers are bumped: MetaMask/core#5073

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested review from a team as code owners December 17, 2024 11:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements) labels Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 17, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6edaca0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb270d19-e6e1-4f67-98f5-64f987c377e2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/nanoid@3.3.8 None 0 57.1 kB ai

🚮 Removed packages: npm/nanoid@3.3.7

View full report↗︎

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 17, 2024
@tommasini tommasini enabled auto-merge December 17, 2024 15:31
@cortisiko cortisiko added No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. and removed Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements) labels Dec 17, 2024
@jake-perkins jake-perkins added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Dec 17, 2024
@tommasini tommasini added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 17f138e Dec 17, 2024
62 of 65 checks passed
@tommasini tommasini deleted the core/resolve-nanoid-version branch December 17, 2024 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 17, 2024
@metamaskbot metamaskbot added the release-99.100.99 Issue or pull request that will be included in release 99.100.99 label Dec 17, 2024
@jake-perkins jake-perkins removed the release-99.100.99 Issue or pull request that will be included in release 99.100.99 label Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants