Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add Asset watch e2e #12720

Merged
merged 3 commits into from
Dec 17, 2024
Merged

test: add Asset watch e2e #12720

merged 3 commits into from
Dec 17, 2024
+87 −2

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Dec 16, 2024 •
edited
Loading

Description

In an effort to increase our overall e2e test coverage, this PR aims to add E2E coverage for Importing a token via the asset watch flow. The test steps are as follows:

Launch app connected to test dapp
Go to test dapp with a deployed ERC20 contract
Tap on Add tokens to the wallet
Verify Asset Watch BottomSheet appears
Then Tap Add
Verify that the imported token is displayed in the wallet view

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko self-assigned this Dec 16, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 16, 2024
@cortisiko cortisiko marked this pull request as ready for review December 16, 2024 20:58
@cortisiko cortisiko requested review from a team as code owners December 16, 2024 20:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9a1d425
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a98903b-f2bb-4032-a91b-4587ae65d65f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

salimtb
salimtb previously approved these changes Dec 16, 2024
View reviewed changes
@EtherWizard33 EtherWizard33 self-requested a review December 17, 2024 12:19
EtherWizard33
EtherWizard33 previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

OGPoyraz
OGPoyraz previously approved these changes Dec 17, 2024
View reviewed changes
@cortisiko cortisiko dismissed stale reviews from OGPoyraz, EtherWizard33, and salimtb via 238255b December 17, 2024 15:04
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 238255b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3cca9afc-293e-4c71-9b15-411aadc40d6b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

NicolasMassart
NicolasMassart approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cortisiko
Copy link
Member Author

The e2e tests are now failing because of a backend issue that started today. I am going to merge this PR based on the fact that the tests ran and passed yesterday: #12720 (comment)

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 17, 2024
@cortisiko cortisiko enabled auto-merge December 17, 2024 17:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cortisiko cortisiko added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit b382fd6 Dec 17, 2024
42 checks passed
@cortisiko cortisiko deleted the detox/add-asset-watch-e2e branch December 17, 2024 17:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@metamaskbot metamaskbot added the release-99.100.99 Issue or pull request that will be included in release 99.100.99 label Dec 17, 2024
@cortisiko cortisiko added release-7.39.0 Issue or pull request that will be included in release 7.39.0 and removed release-99.100.99 Issue or pull request that will be included in release 99.100.99 labels Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sleepytanya sleepytanya sleepytanya approved these changes

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@EtherWizard33 EtherWizard33 EtherWizard33 left review comments

@salimtb salimtb salimtb left review comments

@OGPoyraz OGPoyraz OGPoyraz left review comments

Assignees

@cortisiko cortisiko

Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cortisiko @NicolasMassart @OGPoyraz @salimtb @sleepytanya @EtherWizard33 @metamaskbot