Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add e2e to clear privacy data #12715

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Dec 16, 2024

Description

In an effort to increase our overall e2e test coverage, this PR aims to add E2E coverage for the clear privacy flow. The test steps are as follows:

  • Launch app connected to test dapp
  • Verify that the account is connected to test dapp
  • Go to privacy and security and clear privacy data
  • Verify that account is no longer connected to test dapp

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko self-assigned this Dec 16, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f55a90e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9c02d9f2-fa95-47c9-bda5-3548fb298d94

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added the No QA Needed Apply this label when your PR does not need any QA effort. label Dec 16, 2024
@cortisiko cortisiko marked this pull request as ready for review December 16, 2024 20:16
@cortisiko cortisiko requested review from a team as code owners December 16, 2024 20:16
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@cortisiko cortisiko added this pull request to the merge queue Dec 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2024
@cortisiko cortisiko added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 750def1 Dec 17, 2024
3 checks passed
@cortisiko cortisiko deleted the detox/add-e2e-to-clear-privacy-data branch December 17, 2024 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@metamaskbot metamaskbot added the release-99.100.99 Issue or pull request that will be included in release 99.100.99 label Dec 17, 2024
@cortisiko cortisiko added release-7.39.0 Issue or pull request that will be included in release 7.39.0 and removed release-99.100.99 Issue or pull request that will be included in release 99.100.99 labels Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants